Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix acceptance tests by adding missing var in parameter #376

Merged
merged 2 commits into from
Sep 17, 2024

Conversation

rcgottlieb
Copy link
Contributor

@rcgottlieb rcgottlieb commented Sep 17, 2024

Changes proposed in this pull request:

  • This fixes the acceptance tests by adding the rds-service var with the appropriate value for the given test
  • Also fixed the bulid-manifest as the env vars weren't formatted properly

Things to check

  • For any logging statements, is there any chance that they could be logging sensitive data?
  • Are log statements using a logging library with a logging level set? Setting a logging level means that log statements "below" that level will not be written to the output. For example, if the logging level is set to INFO and debugging statements are written with log.debug or similar, then they won't be written to the otput, which can prevent unintentional leaks of sensitive data.

Security considerations

None

@rcgottlieb rcgottlieb requested a review from a team as a code owner September 17, 2024 14:47
@rcgottlieb rcgottlieb added this pull request to the merge queue Sep 17, 2024
Merged via the queue into main with commit 750d1ad Sep 17, 2024
1 check passed
@rcgottlieb rcgottlieb deleted the fix-acceptance-tests branch September 17, 2024 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants